search

aws / eks-anywhere-packages

Apache License 2.0
25 stars 27 forks source link

Cleanup unused functions and types in bundle generation code #1156

Closed abhay-krishna closed 1 month ago

abhay-krishna commented 1 month ago

This PR cleans up unused functions and types in the bundle generation codebase. Some of the removals and changes include:

  1. [REMOVAL] Types, functions and references related to ECR Public (since we only need private ECR logic)
  2. [REMOVAL] Client creation methods with logic to create "Release" SDK Clients for ECR, ECR Public and STS (since we are directly creating them using methods offered by aws-sdk-go-v2).
  3. [REMOVAL] Types ImageDetailsBothECR, ImageDetailsECR and conversion methods to/from github.com/aws/aws-sdk-go-v2/service/ecr/types.ImageDetail type to these new types (since we are only dealing with private ECR)
  4. [REMOVAL] Unnecessary private registries in Docker config.json and Skopeo policy.json configuration files (since we only push to a single private ECR)
  5. [MODIFICATION] Mock types changes and registry changes to keep tests happy

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

abhay-krishna commented 1 month ago

/approve

eks-distro-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhay-krishna

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/aws/eks-anywhere-packages/blob/main/OWNERS)~~ [abhay-krishna] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
sp1999 commented 1 month ago

/lgtm