search

aws / eks-anywhere-packages

Apache License 2.0
24 stars 27 forks source link

Clear status for a successful reconciliation in processInstalled function #964

Open vincentni opened 1 year ago

vincentni commented 1 year ago

What happened: For an installed package, if the previous run of reconciliation ran into an error, such error message won't get cleared in subsequent successful runs of reconciliation if no config changes are made to that installed package.

What you expected to happen: The status detail of a package resource should be cleared if the current reconciliation succeeds. The relevant code is https://github.com/aws/eks-anywhere-packages/blob/main/pkg/packages/manager.go#L177-L219.

TerryHowe commented 1 year ago

I recall there was a bug regarding clearing Detail early on and I think this issue represents that problem. The customer was running a very old version of the controller, it did not clear status. They installed a new controller and it would not have the same issue, but until they upgrade, it will not update Detail.