Open danbudris opened 2 years ago
@danbudris Do we have clearly defined log levels. It seems like theres a mashup of logger.V(<some number that vaguely seems appropriate at the time>)
right now?
so there are in fact defined log levels which we should apply here (see https://github.com/aws/eks-anywhere/blob/main/pkg/logger/doc.go#L12),
If the EKS A CLI fails, and then attempts to collect a support bundle, but the target cluster is inaccessible, the bundle collection produces loud and alarming logs indicating that it failed to collect. This should be revisited, and we should ensure that if the bundle collection fails because of the cluster being inaccessible it is made clear to the customer.
We should also move more of the bundle collection logs into the debug logs to avoid noise in the ux.
example failure:
Something failed on the bootstrap cluster and then diag bundle failed. Not sure what failed on bootstrap (the guy cleaned up everything, so can’t tell now), but what’s this diag bundle error?