aws / eks-anywhere

Run Amazon EKS on your own infrastructure 🚀
https://anywhere.eks.amazonaws.com
Apache License 2.0
1.96k stars 284 forks source link

EKS Anywhere should validate that user-provided taints do not have duplicate keys #2588

Open danbudris opened 2 years ago

danbudris commented 2 years ago

Kubernetes does not support taints with duplicate keys on the same nodes.

Attempting to join a node with duplicate taint keys results in an error.

EKS Anywhere does not validate that user-provided taints have distinct keys.

A validation should be added to ensure that taints provided in their the CP config or WN config have distinct keys.

jiayiwang7 commented 2 years ago

Validation on Kubernetes: https://github.com/kubernetes/kubernetes/blob/master/pkg/apis/core/validation/validation.go#L4991