aws / eks-anywhere

Run Amazon EKS on your own infrastructure 🚀
https://anywhere.eks.amazonaws.com
Apache License 2.0
1.94k stars 277 forks source link

Support /dev/vda in hardware.csv for tinkerbell #5546

Open d8660091 opened 1 year ago

d8660091 commented 1 year ago

When deploy EKSA on KVM machines with Tinkerbell, disk is marked as /dev/vda in hardware.csv.

The Tinkerbell action generated would be invalid in this case.

Expected disk of of write-netplan action: /dev/vda2. Actual: /dev/vda

EKSA version: v0.15.1

Related: https://github.com/tinkerbell/tink/blob/187f9a6c181fa1560282b97d2fb4689f48e1e62e/internal/workflow/template_funcs.go#L13

chrisdoherty4 commented 1 year ago

Raised an issue in upstream Tinkerbell as this is currently unsupported as noted in the OP.

https://github.com/tinkerbell/tink/issues/704

Removed bug tag as this isn't a bug, its unsupported.