aws / eks-charts

Amazon EKS Helm chart repository
Apache License 2.0
1.2k stars 973 forks source link

Upgrade fluentbit chart with image and new set of config values #901

Open aws-cpg-deep opened 1 year ago

aws-cpg-deep commented 1 year ago

Is your feature request related to a problem? There have been significants updates to fluentbit, specially cloudwatch plugin in recent times. In recent times, they have released a new plugin cloudwatch_logs which brings in tons of feature like ability to define log_group_template which allows to create cloudwatch log groups dynamically.

It new plugin cloudwatch_logs should replace the aws/amazon-cloudwatch-logs-for-fluent-bit Golang Fluent Bit plugin released last year as recommended by repository readme. The Golang plugin was named cloudwatch; this new high performance CloudWatch plugin is called cloudwatch_logs to prevent conflicts/confusion.

I think this problem surfaces an issue where customers should be able to override config maps like one can override settings like container image while it can continue to have current implementation for abstractions. This way helm-charts can stay agile and updated.

Is your feature request related to a specific Helm chart, if yes mention name of the chart? fluent-bit

Describe the solution you'd like Ability to override config map for fluent bit as a whole

Describe alternatives you've considered Continually update new settings and plugin with new releases and implement similar one for cloudwatch_logs

wesmiles commented 1 year ago

This enhancement would be extremely useful for the project I am currently working on and I'm sure others too. We have a requirement on a shared EKS cluster to segregate CloudWatch logs on a per namespace level. The ability to configure this is currently blocked as we don't have access to configure it within the helm chart, e.g. to configure log_group_template and log_stream_template.

dnaprawa-capgemini commented 1 year ago

Looking forward for implementing log_group_template and log_stream_template parameters. It's super important and needed for a project I am currently working on.