search

aws / eks-distro-build-tooling

This repository contains tooling used to build the EKS Distro, and all the projects contained in https://github.com/aws/eks-distro.
https://distro.eks.amazonaws.com/
Apache License 2.0
77 stars 62 forks source link

add go 1.23 image and license image to builder-base Dockerfile #1502

Closed vineeth-bandi closed 2 months ago

vineeth-bandi commented 2 months ago

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

vineeth-bandi commented 2 months ago

/approve

eks-distro-bot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vineeth-bandi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/aws/eks-distro-build-tooling/blob/main/OWNERS)~~ [vineeth-bandi] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
xdu31 commented 2 months ago

/lgtm

srbgupta86 commented 2 months ago

Shouldn't we define GOLANG_VERSION_123 in https://github.com/aws/eks-distro-build-tooling/blob/main/builder-base/versions.yaml?

vineeth-bandi commented 2 months ago

Shouldn't we define GOLANG_VERSION_123 in https://github.com/aws/eks-distro-build-tooling/blob/main/builder-base/versions.yaml?

Thats included in the previous PR #1501.