Disable wildcard imports within the package. - Githubissues

aws / event-ruler

Event Ruler is a Java library that allows matching many thousands of Events per second to any number of expressive and sophisticated rules.

Apache License 2.0

556 stars 58 forks source link

Disable wildcard imports within the package. #132

Closed baldawar closed 7 months ago

baldawar commented 7 months ago

Issue #, if available:

Description of changes:

See https://checkstyle.sourceforge.io/apidocs/com/puppycrawl/tools/checkstyle/checks/imports/AvoidStarImportCheck.html for more context

Rationale: Importing all classes from a package or static members from a class leads to tight coupling between packages or classes and might lead to problems when a new version of a library introduces name clashes.

Also ran IDE-based optimize imports. Fixes a missed comment from a previous PR https://github.com/aws/event-ruler/pull/129#discussion_r1403574719

Benchmark / Performance (for source code changes):

N/A

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.