… patterns were contained in its sibling sub-rules, even if no sibling contained all of the keys and patterns by itself.
Description of changes:
Fixing bug where sub-rule would not be considered new if its keys and patterns were contained in its sibling sub-rules, even if no sibling contained all of the keys and patterns by itself. This would result in that sub-rule not being matchable. To avoid adversely affecting performance, this required adding a mapping of sub-rule name to IDs in SubRuleContext.Generator. While doing this, I also moved the mapping of sub-rule ID to name out of NameState and into SubRuleContext.Generator. For most cases, this will be a net memory improvement (despite the additional mapping), as there is a single SubRuleContext.Generator at the Machine level, where as there are many NameStates at the Machine level, so the ID to name mapping would be stored redundantly many times.
… patterns were contained in its sibling sub-rules, even if no sibling contained all of the keys and patterns by itself.
Description of changes:
Fixing bug where sub-rule would not be considered new if its keys and patterns were contained in its sibling sub-rules, even if no sibling contained all of the keys and patterns by itself. This would result in that sub-rule not being matchable. To avoid adversely affecting performance, this required adding a mapping of sub-rule name to IDs in SubRuleContext.Generator. While doing this, I also moved the mapping of sub-rule ID to name out of NameState and into SubRuleContext.Generator. For most cases, this will be a net memory improvement (despite the additional mapping), as there is a single SubRuleContext.Generator at the Machine level, where as there are many NameStates at the Machine level, so the ID to name mapping would be stored redundantly many times.
Benchmark / Performance (for source code changes):
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.