aws / fmeval

Foundation Model Evaluations Library
http://aws.github.io/fmeval
Apache License 2.0
155 stars 40 forks source link

Failed running ./devtool: line 14: pre-commit: command not found #162

Closed gilinachum closed 5 months ago

gilinachum commented 6 months ago

Using MacOS

.venv) (base) 682f678a18ea:fmeval gili$ sh +x ./devtool all
+ set +x
CD -> /Users/gili/dev/fmeval
==================
all
==================
OS Type: darwin22
-n Python version: 
Python 3.10.0

Detected darwin OS Type, setting OBJC_DISABLE_INITIALIZE_FORK_SAFETY in env

Lint checks
-e ===========

1. pre-commit hooks
===================
./devtool: line 14: pre-commit: command not found
gilinachum commented 6 months ago

Solved with

These packages are needed to run ./devtool all successfully: pip install pre-commit flake8 mypy lxml

Fix poetry SSL issue: /Applications/Python\ 3.10/Install\ Certificates.command

Fix: sed: illegal option -- z by manually adding poetry to path by adding to ~/.bash_profile this line: export PATH="/Users/gili/.local/bin:$PATH"

Then poetry continues to install needed packages.

keerthanvasist commented 5 months ago

Interesting. Thanks you for bringing up this observation @gilinachum. We will update the build scripts accordingly.

keerthanvasist commented 5 months ago

Closing this request as #174 fixes the issue. @gilinachum thanks for reporting this. Please re-open if the issue still persists.