search

aws / glide-for-redis

Apache License 2.0
152 stars 29 forks source link

Java: Add `FUNCTION LOAD` command. #1425

Closed Yury-Fridlyand closed 3 weeks ago

Yury-Fridlyand commented 4 weeks ago

Issue #, if available: N/A

Description of changes: https://redis.io/docs/latest/commands/function-load/

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Yury-Fridlyand commented 3 weeks ago

no doubt, functionLoadWithReplace should be replaced to functionLoadReplace my question is if we can name both functionLoad and just have on with a boolean parameter.

Will rename. We don't convert redis command keywords into arguments. In all cases these keywords change command behavior and in most cases - change return type. Here we don't have return type changed, but to be consisent we decided to implement that command with two functions.