aws / graph-explorer

React-based web application that enables users to visualize both property graph and RDF data and explore connections between data without having to write graph queries.
https://github.com/aws/graph-explorer
Apache License 2.0
314 stars 46 forks source link

[Feature Request] PNPM mono repo setup is sub-optimal #303

Closed kmcginnes closed 4 months ago

kmcginnes commented 4 months ago

Description

The way the repo is configured, which I'm guessing happened over time, has led to odd mechanics when working on the code.

ESLint and Prettier are configured to work within the {root}/packages/graph-explorer folder, but not from the root. This means I need to open VSCode at that folder to have the configuration work properly in the editor.

It's also unclear how to manage dependencies. There are pnpm-lock.yaml files at the root and inside each package folder. Typically, mono repos will have a single lock file at the root and everything is managed from the root, never the package folders.

Developers should be able to open the code base from the root folder and work within both the React app and the server app using the same editor. Further, ESLint and Prettier should be setup to work across the entire code base.

Preferred Solution

Additional Context

Other potential improvements that will likely be separate pull requests or issues:


[!TIP] Please use a 👍 reaction to provide a +1/vote.

This helps the community and maintainers prioritize this request.

[!IMPORTANT] If you are interested in working on this issue or have submitted a pull request, please leave a comment.

kmcginnes commented 4 months ago

All the tasks in the "Additional Context" section have been moved to new GitHub issues.

That means this issue has been completed.