search

aws / graph-explorer

React-based web application that enables users to visualize both property graph and RDF data and explore connections between data without having to write graph queries.
https://github.com/aws/graph-explorer
Apache License 2.0
300 stars 46 forks source link

[Feature Request] Prefer HTTP GET over POST #401

Closed JervenBolleman closed 1 month ago

JervenBolleman commented 1 month ago

Description

A http GET request is easier to cache than a POST request. Considering the repeated nature of some of the queries this might give a big performance increase.

Preferred Solution

If a request can be a GET use a GET instead of a POST (URL lenght < 700 chars).

Additional Context

Caching POST requests is unusual and quite hard per https://www.rfc-editor.org/rfc/rfc7231

Related Issues

Tasks

[!IMPORTANT] If you are interested in working on this issue or have submitted a pull request, please leave a comment.

[!TIP] Please use a 👍 reaction to provide a +1/vote.

This helps the community and maintainers prioritize this request.

kmcginnes commented 1 month ago

💯% agree, that's why we are working on it 😄

Checkout #358 for the details.

We are planning to use TanStack Query as a wrapper around the POST requests which will give us caching back at the client level.

kmcginnes commented 1 month ago

Closing to reduce confusion and focus on #358