React-based web application that enables users to visualize both property graph and RDF data and explore connections between data without having to write graph queries.
This turned out to be way larger than I expected. Apparently many parts of the app are intertwined with the neighbor counts. Decoupling that logic has been tough and led to exposing many bugs in other parts of the system.
As it stands right now this PR accomplishes the following:
Deferred Neighbor Counts
Converts neighbor counts query to React Query useQuery() and Recoil
Updates node badges to use deferred neighbor counts
Updates expand side bar panel to use deferred neighbor counts
Updates table view to use deferred neighbor counts
Removes neighbor counts from Vertex data
Uses "-" in node badge to indicate loading
Expand Node Action
Converts expand node to a React Query useQuery()
Uses notifications for progress and error states for the expand process
Updates expand side bar panel to use new expand node action
Removes limit on double click to expand
Removes auto selecting new nodes on expansion (now the expanded node remains selected)
Remaining Issues
This are the issues I am aware of and still need to be addressed before we can consider this PR ready.
[ ] Remove all WIP commits and TODO comments
[ ] SPARQL queries can include blank node neighbors, which may not be working with the new neighbor counts API
[ ] Neighbor limits were always a little broken, but now they are more so. The limits are currently removed entirely. I'm considering if they need to be added back and in what way.
[ ] Make right click context menu expand action mimic the double click action
[ ] Performance expanding many neighbors
[ ] Swipr errors in keyword search item details
[ ] Double click hit area is too small
Validation
Related Issues
Resolves #341
Resolves #339
Resolves #318
Resolves #338
Check List
[x] I confirm that my contribution is made under the terms of the Apache 2.0
license.
[x] I have run pnpm checks to ensure code compiles and meets standards.
[x] I have run pnpm test to check if all tests are passing.
[ ] I have covered new added functionality with unit tests if necessary.
kmcginnes
commented
3 weeks ago
Description
This turned out to be way larger than I expected. Apparently many parts of the app are intertwined with the neighbor counts. Decoupling that logic has been tough and led to exposing many bugs in other parts of the system.
As it stands right now this PR accomplishes the following:
Deferred Neighbor Counts
useQuery()and RecoilVertexdataExpand Node Action
useQuery()Remaining Issues
This are the issues I am aware of and still need to be addressed before we can consider this PR ready.
Validation
Related Issues
Check List
pnpm checksto ensure code compiles and meets standards.pnpm testto check if all tests are passing.Changelog.md.