search

aws / graph-explorer

React-based web application that enables users to visualize both property graph and RDF data and explore connections between data without having to write graph queries.
https://github.com/aws/graph-explorer
Apache License 2.0
299 stars 46 forks source link

Remove all class name prefix logic #469

Closed kmcginnes closed 4 days ago

kmcginnes commented 1 week ago

Description

This change removes all the logic dealing with dynamic class name prefixes in the app's CSS styling.

I can't find any reason for this logic to exist. It is a solution in search of a problem. And it amounts to a ton of noise in the code that makes creating new components a friction filled experience.

Validation

After removing all the class name logic I tried testing out all the different controls in the UI. I even went searching for the parts of the app that I don't use very often, like the table views, export, style customization, legend, etc. Everything seems to work find and looks as it did before.

Related Issues

Check List

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 0.08703% with 1148 lines in your changes missing coverage. Please review.

Project coverage is 15.01%. Comparing base (361c4ba) to head (91440db). Report is 52 commits behind head on main.

:exclamation: Current head 91440db differs from pull request most recent head e55e47e

Please upload reports for the commit e55e47e to get more accurate results.

Files Patch % Lines
...rc/components/AdvancedList/AdvancedList.styles.tsx 0.00% 203 Missing :warning:
...dules/NodesStyling/SingleNodeStylingModal.style.ts 0.00% 59 Missing :warning:
...-explorer/src/modules/EntityDetails/EdgeDetail.tsx 0.00% 47 Missing :warning:
...nents/Workspace/components/HideNavBarLogo.style.ts 0.00% 44 Missing :warning:
...graph-explorer/src/modules/common/VertexHeader.tsx 0.00% 33 Missing :warning:
...les/GraphViewer/internalComponents/ContextMenu.tsx 0.00% 31 Missing :warning:
...rc/modules/EdgesStyling/SingleEdgeStyling.style.ts 0.00% 28 Missing :warning:
...rc/modules/NodesStyling/SingleNodeStyling.style.ts 0.00% 28 Missing :warning:
...dules/EdgesStyling/SingleEdgeStylingModal.style.ts 0.00% 25 Missing :warning:
...plorer/src/modules/KeywordSearch/KeywordSearch.tsx 0.00% 24 Missing :warning:
... and 85 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #469 +/- ## ========================================== + Coverage 13.97% 15.01% +1.03% ========================================== Files 414 420 +6 Lines 30639 30378 -261 Branches 878 962 +84 ========================================== + Hits 4283 4561 +278 + Misses 26026 25485 -541 - Partials 330 332 +2 ``` | [Flag](https://app.codecov.io/gh/aws/graph-explorer/pull/469/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/aws/graph-explorer/pull/469/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws) | `15.01% <0.08%> (+1.03%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kmcginnes commented 1 week ago

We should hold this change until after the v1.8.0 release.