Fix swiper error - Githubissues

aws / graph-explorer

React-based web application that enables users to visualize both property graph and RDF data and explore connections between data without having to write graph queries.

https://github.com/aws/graph-explorer

Apache License 2.0

317 stars 47 forks source link

Fix swiper error #474

Closed kmcginnes closed 3 months ago

kmcginnes commented 3 months ago

Description

In the search modal when the user selects a search result you would see a error in the browser's console.

This was caused by the use of setTimeout() within a useEffect(). This is almost never a good idea.

I have replaced it with useTransition(), which is the React supported way of delaying a task until the next render.

Validation

Verified no more error
Verified multiple selection still works
Verified swiping still works
Verified prev/next buttons work

The original error

CleanShot 2024-07-03 at 18 27 27@2x

Related Issues

Fixes #435

Check List

[x] I confirm that my contribution is made under the terms of the Apache 2.0 license.
[x] I have run pnpm checks to ensure code compiles and meets standards.
[x] I have run pnpm test to check if all tests are passing.
[ ] I have covered new added functionality with unit tests if necessary.
[x] I have added an entry in the Changelog.md.

kmcginnes commented 3 months ago

@vkagamlyk Fixed