fix: error messages are getting lost - Githubissues

aws / jsii-compiler

The jsii compiler for TypeScript

https://aws.github.io/jsii/

Apache License 2.0

29 stars 15 forks source link

fix: error messages are getting lost #1263

Closed mrgrain closed 2 months ago

mrgrain commented 2 months ago

All errors encountered jsii used to print in the following order:

Any logging output (might be empty)
Full CLI help
Actual error including stack trace

This has a few downsides:

logging output is hidden from view due to long cli help
cli help is not useful in most cases
stack trace is not relevant to solving the error

Instead we now print

Any logging output
CLI help only if explicitly requested by the error
Just the error message with a nice red prefix

Also deletes some compiled js files that were incorrectly checked-in to the repo when it was migrated from aws/jsii.

Previously:

[...]

Now:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

aws-cdk-automation commented 2 months ago

💚 All backports created successfully

Status	Branch	Result
✅	maintenance/v5.3
✅	maintenance/v5.4

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details