search

aws / jsii-rosetta

The jsii sample code transliterator
https://aws.github.io/jsii
Apache License 2.0
18 stars 11 forks source link

(python) Incorrect docs translation of three letter acronyms in property names #872

Open mrgrain opened 7 months ago

mrgrain commented 7 months ago

https://docs.aws.amazon.com/cdk/api/v2/python/aws_cdk.aws_ecs/ServiceManagedEBSVolumeConfiguration.html

Is managed_eBSVolume Should be managed_ebs_volume

        volume = ecs.ServiceManagedVolume(self, "EBSVolume",
            name="ebs1",
            managed_ebs_volume=ecs.ServiceManagedEBSVolumeConfiguration(
                size= Size.gibibytes(15),
                volume_type=ec2.EbsDeviceVolumeType.GP3,
                file_system_type=ecs.FileSystemType.XFS,
                tag_specifications=[ecs.EBSTagSpecification(
                    tags={
                        "purpose": "production"
                    },
                    propagate_tags=ecs.EbsPropagatedTagSource.SERVICE
                )]
            )
        )
iliapolo commented 6 months ago

@mrgrain this is a bug with generated example code only, right?

mrgrain commented 6 months ago

I thought it's a bug with transliterating an example from TS to Python. But I might be wrong.

iliapolo commented 6 months ago

Yeah it might be that, I just meant its not a runtime issue, but a doc issue 👍