search

aws / jsii

jsii allows code in any language to naturally interact with JavaScript classes. It is the technology that enables the AWS Cloud Development Kit to deliver polyglot libraries from a single codebase!
https://aws.github.io/jsii
Apache License 2.0
2.63k stars 244 forks source link

Generated python docs incorrectly adds underscore to prop #3516

Open peterwoodworth opened 2 years ago

peterwoodworth commented 2 years ago

Describe the bug

The generated Python docs incorrectly shows memory_limit_mi_b as the property when there should be no underscore in mi_b. Seen here

This is likely because Python is detecting the capital B as a new "word"

Expected Behavior

docs show memory_limit_mib

Current Behavior

docs show memory_limit_mi_b

Reproduction Steps

https://docs.aws.amazon.com/cdk/api/v2/python/aws_cdk.aws_ecs_patterns/ApplicationLoadBalancedFargateService.html https://docs.aws.amazon.com/cdk/api/v2/python/aws_cdk.aws_ecs_patterns/ApplicationLoadBalancedFargateServiceProps.html

Possible Solution

No response

Additional Information/Context

No response

SDK version used

.

Environment details (OS name and version, etc.)

.

kmanuwai commented 3 months ago

Still an issue. To make it work have to change memory_limit_mi_b to memory_limit_mib in ecs_patterns.ApplicationLoadBalancedFargateService.

This issue is leading to incorrect code to be propagated at least here, where else may this issue be propagating incorrect code?