Ensure that some End to End tests run with a -race build

[tzneal]

Tell us about your request

At least some portion (possibly all?) e2e tests should run with a -race build.

Tell us about the problem you're trying to solve. What are you trying to do, and why is it hard?

Since concurrent reconciles can occur we want to ensure that our reconcilers are race free. Unit testing can be helpful, but a full e2e test with a -race build will be more effective at identifying issues.

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

[spring1843]

Doesn't this mean they are all running with -race? https://github.com/aws/karpenter/blob/main/Makefile#L35

[tzneal]

Doesn't this mean they are all running with -race? https://github.com/aws/karpenter/blob/main/Makefile#L35

The units tests are running with the race detector, but I don't know if there are any end to end tests yet. This issue was to ensure that those tests, when they exist, are run with -race as well.

[engedaam]

-race injects artificial timing delays to goroutines, which might not be ideal for our e2etests

[jonathan-innis]

-race injects artificial timing delays to goroutines, which might not be ideal for our e2etests

This isn't what -race does. -race detects data races in our E2E testing to ensure that we aren't writing race-y tests that have potential to cause data races and data corruption. It seems like good hygiene to have this in our go test call if nothing more than catching data races in our test code that we have accidentally written in.