Support for AWS placement group strategies

pincher95 commented 1 year ago

Tell us about your request

Support to schedule node based on placement group strategies. As example when you launch a new EC2 instance, the EC2 service attempts to place the instance in such a way that all of your instances are spread out across underlying hardware to minimize correlated failures. You can use placement groups to influence the placement of a group of interdependent instances to meet the needs of your workload.

Tell us about the problem you're trying to solve. What are you trying to do, and why is it hard?

Need to provision ETCD cluster in the same AZ.

Are you currently working around this issue?

Using ASG with launch template configured to use placement group.

Additional Context

No response

Attachments

No response

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

preflightsiren commented 1 year ago

I'm about to close out #3859 do you have a sense of which fields you'd like to see implemented? if so I'd be happy to extend my PR to cover some other scenarios.

pincher95 commented 1 year ago

@preflightsiren Hey, i would like to see groupId implemented which is placement group id ( E.g pg-xxxxxxxxxxxxxxxxx ) the same way it implemented in LT

Thanks

preflightsiren commented 1 year ago

I've added support in https://github.com/aws/karpenter/pull/3859 - once I can get that PR approved and merged, we should be able to get support for placement.groupId in the awsnodetemplate

pincher95 commented 1 year ago

@preflightsiren that amazing

Thank you

pincher95 commented 10 months ago

@preflightsiren Is #3859 been promoted or scrapped?

preflightsiren commented 10 months ago

have to change the approach to improve discovery / make configuration more portable between geographies and clusters. I'm working on it now.

giusedroid commented 7 months ago

Hey folks! Any updates on this?

vara-bonthu commented 2 weeks ago

I understand the requirement for placement group creation by Karpenter, similar to what is done today with managed node groups for worker nodes running high-performance workloads like ML training, etc.

Need to provision ETCD cluster in the same AZ.

Could you elaborate more on why your requirement specifically needs a placement group for ETCD servers?

aws / karpenter-provider-aws