aws / karpenter-provider-aws

Karpenter is a Kubernetes Node Autoscaler built for flexibility, performance, and simplicity.
https://karpenter.sh
Apache License 2.0
6.89k stars 970 forks source link

Error for `KubeletConfiguration` that isn't supported for an AMIFamily #3722

Open jonathan-innis opened 1 year ago

jonathan-innis commented 1 year ago

Tell us about your request

There are some pieces of the v1alpha5.KubeletConfiguration that aren't supported by Bottlerocket AMIFamily. Rather than silently ignoring these pieces, we should error to the user that we can't launch when there are pieces of the kubeletConfiguration that aren't supported by the AMIFamily

Tell us about the problem you're trying to solve. What are you trying to do, and why is it hard?

N/A

Are you currently working around this issue?

Silently ignoring v1alpha5.KubeletConfiguration that isn't supported by the AMIFamily

Additional Context

No response

Attachments

No response

Community Note

jonathan-innis commented 1 year ago

Currently, the fields that aren't supported by Bottlerocket but are supported by the Karpenter kubeletConfiguration are:

  1. evictionSoft
  2. podsPerCore
  3. cpuCFSQuota
srinchow commented 1 year ago

@jonathan-innis i can take this up if this needs to be done

stmcginnis commented 1 year ago

Small update on the unsupported fields listed above.

settings.kubernetes.cpu-cfs-quota-enforced and settings.kubernetes.eviction-soft* settings are available as of Bottlerocket 1.14.0 and later. 1.14.0 was released in May 11, so hopefully any new deployments would be using a release that includes these settings.

ecerulm commented 3 months ago

Related: Add Bottlerocket support for kubeletConfiguration.evictionSoft #4271 Related: chore: add bottlerocket support for kubeletconfiguration evictionsoft #6760 Related: chore: Add soft eviction setting to Bottlerocket kublet config #6390

diranged commented 3 months ago

Agreed btw ... I spent a few hours last night trying to understand why settings were not being applied, until I went digging through the code. Thanks for beginning work on this.