aws / karpenter-provider-aws

Karpenter is a Kubernetes Node Autoscaler built for flexibility, performance, and simplicity.
https://karpenter.sh
Apache License 2.0
6.68k stars 935 forks source link

Support Trainium instance types #3885

Closed ellistarn closed 1 year ago

ellistarn commented 1 year ago

Tell us about your request

Karpenter is not aware of aws.amazon.com/neuron resources on the trn instance family.

Tell us about the problem you're trying to solve. What are you trying to do, and why is it hard?

I'd like to use the Trainium instance types with Karpenter. However, karpenter is not aware that this family has aws.amazon.com/neuron resources: https://github.com/aws/karpenter/blob/main/pkg/providers/instancetype/types.go#L223.

Are you currently working around this issue?

n/a

Additional Context

No response

Attachments

No response

Community Note

prabhjotsingh18 commented 1 year ago

Hey @ellistarn I would like to work on this. I'm new to AWS, if you can guide me a little on how to get started that would be great. Thanks

ellistarn commented 1 year ago

I'd start here: https://karpenter.sh/v0.27.3/contributing/development-guide/

It should be about 3 lines of code to make this work. Plus integration testing. Use the inferentia code I linked above as a guide.

sarthaknimbalkar commented 1 year ago

Hey @prabhjotsingh18, I might have found the solution to this, if you working on this please let me know or else i would like to open a pr. Thanks.

prabhjotsingh18 commented 1 year ago

hey @sarthaknimbalkar, please open a PR. so sorry for the late response.

sarthaknimbalkar commented 1 year ago

@prabhjotsingh18 No problem and thanks for reaching back :)