aws / karpenter-provider-aws

Karpenter is a Kubernetes Node Autoscaler built for flexibility, performance, and simplicity.
https://karpenter.sh
Apache License 2.0
6.62k stars 922 forks source link

Fix globbing across all script files #5061

Open jonathan-innis opened 10 months ago

jonathan-innis commented 10 months ago

Description

How can the docs be improved?

We should fix all instances of potential globbing in our scripting files, including instances of when we call helm install commands. This effectively means that we should add double quotes around any instance of a bash variable in a shell script or command.

Stuckinrecoverymode commented 10 months ago

Yeah, I totally agree about that. #5025