aws / karpenter-provider-aws

Karpenter is a Kubernetes Node Autoscaler built for flexibility, performance, and simplicity.
https://karpenter.sh
Apache License 2.0
6.89k stars 970 forks source link

Add ArtifactHub Karpenter Provovider AWS repo #5306

Open stevehipwell opened 11 months ago

stevehipwell commented 11 months ago

Description

What problem are you trying to solve? I'd like there to be an official Karpenter Provider AWS repo in ArtifactHub.

@bwagner5 added a repo for the legacy release process which wasn't adopted (but still could be). I've added a repo for the new release process which can either be adopted (see ArtifactHub docs for ownership claim) or I can delete when you're ready to create a repo if you want to use a new name (I used aws-karpenter but am aware that karpenter-provider-aws might have been a better name). You could adopt first and then delete & replace afterwards.

I think you also need to verify as a publisher (docs) and set the chart as official (docs).

I'd be happy to open a PR to support adding and updating the metadata file in the automation.

How important is this feature to you? This should be important to the project for discoverability. I've fixed the automation tooling issues by adding a repo to support this but it's not official so won't help discoverability in the same way that an official repo would.

jonathan-innis commented 11 months ago

This is a great idea! We'd be open to surfacing Karpenter here. What's the maintenance burden to maintain the config on ArtifactHub? Mainly just making sure the work to update this release-to-release isn't too much to have to reason about for the maintainers.

stevehipwell commented 11 months ago

@jonathan-innis the maintenance cost is either trivial (sync an almost static file to the OCI registry with oras on each release) or a manual one off (I'd advise against this).

The initial one off cost is to set up an ArtifactHub organisation if you don't already have one, then setup the repo, and finally fill out the form to mark the chart as official after it's been verified.

I'm happy to open a PR to cover the maintenance and/or jump on a call to discuss and walk you through the process.

FernandoMiguel commented 11 months ago

here's a tiny example of how argocd updates artifacthub https://github.com/argoproj/argo-helm/pull/2371/files#diff-3d0e405ddca7aa845d30cd372966ac5fb2a00c91c78a533cb5c911f89c6ec404R20

stevehipwell commented 11 months ago

This is how my reusable workflows do it.

https://github.com/action-stars/helm-workflows/blob/fadf7cfa556bb9d25bedf36d5874ce1646be79f5/.github/workflows/release.yaml#L240

stevehipwell commented 11 months ago

@FernandoMiguel I assume you were demonstrating populating the Artifact Hub changelog? This is additional to just having the chart releases show up which doesn't require any release level changes.

ellistarn commented 11 months ago

Who will have permission to the artifact hub account?

jonathan-innis commented 11 months ago

Who will have permission to the artifact hub account?

For the AWS-propogated release, it definitely seems like we need to be the one to own the account, similar to how we own the ECR where we ship the chart and images

I'm happy to open a PR to cover the maintenance and/or jump on a call to discuss and walk you through the process

It sounds like the bulk of the work here is getting the CI setup to get this published on release. I'd be open to a PR once we got the account setup. We can work to coordinate on the Kubernetes slack or through this issue more to get the final pieces in place to make this work.

stevehipwell commented 11 months ago

@jonathan-innis for the AWS release of Karpenter I assume that AWS would want to own the repo so the best pattern would be to create an AWS org to own it. The org can then have multiple members.

stevehipwell commented 8 months ago

@jonathan-innis if you can create an AWS organisation on Artifact Hub you should be able to claim the repo . Once you have the repo I'm happy to have a quick call to walk you through this; it should take less than 10 mins.

I have also configured the NTH repo which can also be claimed.

CC @bwagner5

stevehipwell commented 8 months ago

Artifact Hub charts:

jonathan-innis commented 6 months ago

Looks like this one is done now! Thanks for all the work on this @stevehipwell!

stevehipwell commented 6 months ago

@jonathan-innis I think this should be re-opened as the repos still haven't been transferred.

stevehipwell commented 4 months ago

@dims is this something you could help with? We did something similar for Kubernetes SIGs. Feel free to reach out on Slack if you want to discuss.

CC @jonathan-innis

dims commented 4 months ago

@stevehipwell need to ask one of the current steering folks to do the needful .. https://github.com/kubernetes/steering/issues/188

( as i don't have access to the orgs )

stevehipwell commented 4 months ago

@dims this is specifically about creating an AWS AH org as we did for sigs but owned by AWS.