aws / karpenter-provider-aws

Karpenter is a Kubernetes Node Autoscaler built for flexibility, performance, and simplicity.
https://karpenter.sh
Apache License 2.0
6.84k stars 963 forks source link

Discover Spot Instance Pricing in Isolated VPCs #5587

Open jonathan-innis opened 9 months ago

jonathan-innis commented 9 months ago

Description

What problem are you trying to solve?

Currently, if you set the --isolated-vpc setting, you won't get any pricing information discovered and Karpenter will fully rely on statically created pricing information that is shipped with Karpenter on each release. We made this decision since the AWS price list API is only available in a smaller set of regions; however, this API is only used to discover on-demand pricing information. Spot pricing information is discovered through EC2, which does have a VPC private endpoint.

We can allow spot pricing information to be retrieved, even when you have the --isolated-vpc setting set.

liafizan commented 9 months ago

working on this.

gmembre-zenika commented 9 months ago

It would be great if karpenter can use a proxy for outgoing traffic to query this API. The cluster I work on are located in eu-west-3, the isolated-vpc option is set and the pricing api is only available in eu-central-1 and we don't want to setup a new VPC just for it.

liafizan commented 9 months ago

@gmembre-zenika I think what you are requesting might be another feature request. Perhaps a good idea to open a new request so that it can be tracked based on consensus

fedecz commented 1 month ago

hey @jonathan-innis , @liafizan , has PR #5704 fixed this issue? if so, could we close it? Cheers.