Please add additional parameters to the installation cloudformation template

aws / karpenter-provider-aws

Karpenter is a Kubernetes Node Autoscaler built for flexibility, performance, and simplicity.

https://karpenter.sh

Apache License 2.0

6.18k stars 852 forks source link

Please add additional parameters to the installation cloudformation template #5880

Open gilbahat opened 3 months ago

gilbahat commented 3 months ago

Description

What problem are you trying to solve?

I am trying to better manage and track my karpenter installations and I could use additional parameters on the cloudformation template to that end:

create and use a non-default event bus
customize the policies assigned to the karpenter node role
place the karpenter roles in a non-default IAM path

How important is this feature to you?

These would come very handy, right now I am spending time and effort to track resources across installations.

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

engedaam commented 3 months ago

We do have a cloud formation section to describe all the policy and resources that are used https://karpenter.sh/v0.32/reference/cloudformation/. If I understand your request correctly, you are able to add tags and add in additional resources as needed by updating the CloudFormation YAML.

gilbahat commented 3 months ago

We do have a cloud formation section to describe all the policy and resources that are used https://karpenter.sh/v0.32/reference/cloudformation/. If I understand your request correctly, you are able to add tags and add in additional resources as needed by updating the CloudFormation YAML.

well, one is also able to add those tags manually or otherwise make other such changes, but there's a built-in mechanism in cloudformation for adding optional parameters and it would be time-saving and courteous to add this capability to the template itself.

if possible I would like to not need to fork the template or add these post-installation, as this is not so scalable with version template changes and upgrades

engedaam commented 3 months ago

1.) custom tags to be added to resources created by the template

Can you pass in tags adding --tags to the aws cloudformation deploy?

gilbahat commented 3 months ago

1.) custom tags to be added to resources created by the template

Can you pass in tags adding --tags to the aws cloudformation deploy?

Yes that would be better, amending the ticket accordingly.