aws / karpenter-provider-aws

Karpenter is a Kubernetes Node Autoscaler built for flexibility, performance, and simplicity.
https://karpenter.sh
Apache License 2.0
6.68k stars 934 forks source link

test: Fix scale test provisioning spike #6374

Closed jigisha620 closed 3 months ago

jigisha620 commented 3 months ago

Fixes #N/A

Description We have been seeing spikes in the scale tests for provisioning. That's because there are two different tests that are captured by the same metric and the execution times are different for both.

  1. Metric node-dense for node dense scale-up and node dense scale-up with minValues
  2. Metric pod-dense for pod dense scale-up and pod dense scale-up with minValues

Created a different metric for scale up with and without min values. Now we have node-dense, node-dense-min-val, pod-dense, pod-dense-min-val.

How was this change tested?

Does this change impact docs?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

netlify[bot] commented 3 months ago

Deploy Preview for karpenter-docs-prod canceled.

Name Link
Latest commit fe3ced493df193794fe93ef46dbf6766fa18cd3a
Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/6670b865ef56690009d74c4d
coveralls commented 3 months ago

Pull Request Test Coverage Report for Build 9555675267

Details


Files with Coverage Reduction New Missed Lines %
pkg/providers/amifamily/ami.go 1 90.56%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 9543745280: -0.01%
Covered Lines: 5550
Relevant Lines: 6730

💛 - Coveralls