aws / karpenter-provider-aws

Karpenter is a Kubernetes Node Autoscaler built for flexibility, performance, and simplicity.
https://karpenter.sh
Apache License 2.0
6.16k stars 849 forks source link

ci: Increase max retry for the sweeper #6378

Closed engedaam closed 2 weeks ago

engedaam commented 2 weeks ago

Fixes #N/A

Description

How was this change tested?

Does this change impact docs?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

netlify[bot] commented 2 weeks ago

Deploy Preview for karpenter-docs-prod canceled.

Name Link
Latest commit b29caec865e717bd5d20ca43a87692136a7aadde
Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/6671995c1e61b10008c0fe01
coveralls commented 2 weeks ago

Pull Request Test Coverage Report for Build 9566930979

Details


Files with Coverage Reduction New Missed Lines %
pkg/providers/amifamily/ami.go 1 90.56%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 9556663188: -0.01%
Covered Lines: 5550
Relevant Lines: 6730

💛 - Coveralls
rschalo commented 2 weeks ago

What's the schedule for the sweeper again? Why 10 as the max?

engedaam commented 2 weeks ago

The schedule the sweeper is every 12 hours. Giving 10 max retries allows us to attempt to get instance profiles tags with more spread of a delay to allow us to refile the read tokens. The schedule will be as such:

0 | 0.030 | 1 | 0.090 | 2 | 0.210 | 3 | 0.450 | 4 | 0.930 | 5 | 0.150 | 6 | 0.180 | 7 | 0.210 | 8 | 0.240 | 9 | 0.270 |

Updated 1 0.03 2 0.09
3 0.21
4 0.45
5 0.93
6 1.89
7 3.81
8 7.65
9 15.33
10 30.69

jmdeal commented 2 weeks ago

Is the backoff linear or exponential? I'm reading the schedule you wrote as "incremented by 30ms each time" rather than an exponential backoff. I don't think it matters too much, but wanted to clarify before I approve. Otherwise looks good.

engedaam commented 2 weeks ago

I fixed the comment, the backoff is exponential