docs: Update disable disruption on nodepool to use budgets - Githubissues

aws / karpenter-provider-aws

Karpenter is a Kubernetes Node Autoscaler built for flexibility, performance, and simplicity.

https://karpenter.sh

Apache License 2.0

6.68k stars 933 forks source link

docs: Update disable disruption on nodepool to use budgets #6383

Closed jigisha620 closed 3 months ago

jigisha620 commented 3 months ago

Fixes #N/A

Description Our docs currently recommend using do-not-disrupt annotation to enable disruption on nodePool. This PR adds a change to use node disruption budget instead.

How was this change tested? NA

Does this change impact docs?

[x] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[ ] No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

netlify[bot] commented 3 months ago

Deploy Preview for karpenter-docs-prod ready!

Name	Link
Latest commit	59439a3ed22ae956ba253487e8a7bbd25de8d2e6
Latest deploy log	https://app.netlify.com/sites/karpenter-docs-prod/deploys/66730776850bb000088a90e3
Deploy Preview	https://deploy-preview-6383--karpenter-docs-prod.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

coveralls commented 3 months ago

Pull Request Test Coverage Report for Build 9572851274

Details

0 of 0 changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.01%) to 82.467%

Files with Coverage Reduction	New Missed Lines	%
pkg/providers/amifamily/ami.go	1	90.56%
<!--	Total:	1		-->

Totals
Change from base Build 9569831660:	-0.01%
Covered Lines:	5550
Relevant Lines:	6730

💛 - Coveralls

coveralls commented 3 months ago

Pull Request Test Coverage Report for Build 9573343485

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 82.481%

Totals
Change from base Build 9569831660:	0.0%
Covered Lines:	5551
Relevant Lines:	6730

💛 - Coveralls

coveralls commented 3 months ago

Pull Request Test Coverage Report for Build 9575682558

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 82.467%

Totals
Change from base Build 9574761143:	0.0%
Covered Lines:	5550
Relevant Lines:	6730

💛 - Coveralls

coveralls commented 3 months ago

Pull Request Test Coverage Report for Build 9585427614

Details

0 of 0 changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.01%) to 82.467%

Files with Coverage Reduction	New Missed Lines	%
pkg/providers/amifamily/ami.go	1	90.56%
<!--	Total:	1		-->

Totals
Change from base Build 9585118403:	-0.01%
Covered Lines:	5550
Relevant Lines:	6730

💛 - Coveralls