search

aws / karpenter-provider-aws

Karpenter is a Kubernetes Node Autoscaler built for flexibility, performance, and simplicity.
https://karpenter.sh
Apache License 2.0
6.15k stars 849 forks source link

feat: require karpenter startup taint #6388

Open rschalo opened 1 week ago

rschalo commented 1 week ago

Fixes https://github.com/kubernetes-sigs/karpenter/issues/1049

Description Based on implementation discussion, it is required that userdata scripts for starting kubelet include karpenter.sh/unregistered=true:NoExecute as part of the --register-with-taints flag.

How was this change tested? Unit testing and local aws/karpenter-provider-aws deployment. This will be ship with https://github.com/aws/karpenter-provider-aws/pull/6388/

Does this change impact docs?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

coveralls commented 1 week ago

Pull Request Test Coverage Report for Build 9588940099

Details

Files with Coverage Reduction New Missed Lines %
pkg/providers/amifamily/ami.go 1 90.56%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 9574763384: 0.09%
Covered Lines: 5540
Relevant Lines: 6713
💛 - Coveralls
coveralls commented 1 week ago

Pull Request Test Coverage Report for Build 9588958367

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

Files with Coverage Reduction New Missed Lines %
pkg/providers/amifamily/ami.go 1 90.56%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 9574763384: 0.09%
Covered Lines: 5540
Relevant Lines: 6713
💛 - Coveralls
coveralls commented 1 week ago

Pull Request Test Coverage Report for Build 9589049087

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

Files with Coverage Reduction New Missed Lines %
pkg/providers/amifamily/ami.go 1 90.56%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 9574763384: 0.06%
Covered Lines: 5537
Relevant Lines: 6712
💛 - Coveralls
jmdeal commented 1 week ago

Rather than adding this taint manually in each of the different bootstrap methods, what do you think about modeling this taint as a default startup taint on the NodeClaim? This would then be passed into all the bootstrap options here.

coveralls commented 1 week ago

Pull Request Test Coverage Report for Build 9589576123

Details

Totals Coverage Status
Change from base Build 9588967583: 0.07%
Covered Lines: 5538
Relevant Lines: 6712
💛 - Coveralls
coveralls commented 1 week ago

Pull Request Test Coverage Report for Build 9604444537

Details

Files with Coverage Reduction New Missed Lines %
pkg/providers/amifamily/ami.go 1 90.56%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 9588967583: -0.02%
Covered Lines: 5533
Relevant Lines: 6713
💛 - Coveralls
coveralls commented 1 week ago

Pull Request Test Coverage Report for Build 9604451856

Details

Totals Coverage Status
Change from base Build 9588967583: 0.0%
Covered Lines: 5534
Relevant Lines: 6713
💛 - Coveralls
coveralls commented 1 week ago

Pull Request Test Coverage Report for Build 9604881599

Details

Totals Coverage Status
Change from base Build 9588967583: 0.0%
Covered Lines: 5534
Relevant Lines: 6713
💛 - Coveralls
netlify[bot] commented 5 days ago

Deploy Preview for karpenter-docs-prod ready!

Name Link
Latest commit cab3891ea5a16fb9527766bcb75dee6f425e241b
Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/66842b0fd80e1b00088c1f2b
Deploy Preview https://deploy-preview-6388--karpenter-docs-prod.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

coveralls commented 5 days ago

Pull Request Test Coverage Report for Build 9705014791

Details

Totals Coverage Status
Change from base Build 9704659664: 0.08%
Covered Lines: 5790
Relevant Lines: 7307
💛 - Coveralls
coveralls commented 5 days ago

Pull Request Test Coverage Report for Build 9705120982

Details

Totals Coverage Status
Change from base Build 9704659664: 0.07%
Covered Lines: 5789
Relevant Lines: 7307
💛 - Coveralls
coveralls commented 14 hours ago

Pull Request Test Coverage Report for Build 9764556052

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

Files with Coverage Reduction New Missed Lines %
pkg/providers/instancetype/types.go 1 99.37%
pkg/webhooks/webhooks.go 3 0.0%
pkg/fake/ec2api.go 4 87.07%
pkg/apis/v1/ec2nodeclass.go 13 35.0%
pkg/operator/operator.go 23 9.26%
pkg/apis/v1/zz_generated.deepcopy.go 124 16.59%
<!-- Total: 168 -->
Totals Coverage Status
Change from base Build 9704659664: -0.6%
Covered Lines: 5808
Relevant Lines: 7398
💛 - Coveralls
coveralls commented 14 hours ago

Pull Request Test Coverage Report for Build 9764684399

Details

Totals Coverage Status
Change from base Build 9754740262: 0.07%
Covered Lines: 5807
Relevant Lines: 7398
💛 - Coveralls