search

aws / karpenter-provider-aws

Karpenter is a Kubernetes Node Autoscaler built for flexibility, performance, and simplicity.
https://karpenter.sh
Apache License 2.0
6.15k stars 849 forks source link

chore: Add soft eviction setting to Bottlerocket kublet config #6390

Open lolbrish opened 1 week ago

lolbrish commented 1 week ago

Fixes #N/A

Description

Issue https://github.com/bottlerocket-os/bottlerocket/issues/1445 is fixed and so soft eviction settings can now be used with Bottlerocket. It looks like old docs have already been removed that used to discuss this limitation.

How was this change tested?

Tested on a live EKS cluster to provision Bottlerocket nodes, then the kubelet configuration was checked using http://localhost:8001/api/v1/nodes/$NODE/proxy/configz.

Does this change impact docs?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

netlify[bot] commented 1 week ago

Deploy Preview for karpenter-docs-prod canceled.

Name Link
Latest commit 61c9ba3adfdf183818f4b2248116a46c65b463d1
Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/6673ac2dbafeaf00084f0d60
jonathan-innis commented 1 week ago

Thanks for taking this up! A few comments, mainly about testing 👍🏼