aws / karpenter-provider-aws

Karpenter is a Kubernetes Node Autoscaler built for flexibility, performance, and simplicity.
https://karpenter.sh
Apache License 2.0
6.15k stars 849 forks source link

Support karpenter.sh/do-not-disrupt on namespace level #6392

Closed pragmaticivan closed 1 week ago

pragmaticivan commented 1 week ago

Description

What problem are you trying to solve? I could not find docs, so I'm proposing this becomes a feature.

Given a namespace critical, I would like to add karpenter.sh/do-not-disrupt = true to the namespace, so that any pod under that namespace can't be disrupted.

How important is this feature to you?

This would be ideal for multi-tenant clusters where you want to incrementally onboard teams into disruption schedules.

jigisha620 commented 1 week ago

This issue seems more related to kubernetes-sigs/karpenter than being specific to AWS. Also we already have an issue open for this in upstream - https://github.com/kubernetes-sigs/karpenter/issues/1189. Can you close this issue in favor of the upstream issue? Feel free to comment on that issue with your use case for this feature. Thanks!

pragmaticivan commented 1 week ago

yes, thx!