aws / karpenter-provider-aws

Karpenter is a Kubernetes Node Autoscaler built for flexibility, performance, and simplicity.
https://karpenter.sh
Apache License 2.0
6.15k stars 849 forks source link

Admission controller reject "app.kubernetes.io/managed-by" labels on Provisioner #6399

Open loganmzz opened 1 week ago

loganmzz commented 1 week ago

Description

Observed Behavior:

When wanting to add "standard" labels app.kubernetes.io/* resource creation is rejected by adminission controller

Expected Behavior:

Being able to use any app.kubernetes.io/* labels.

Reproduction Steps (Please include YAML):

apiVersion: karpenter.sh/v1alpha5
kind: Provisioner
metadata:
  name: demo
  labels:
    "app.kubernetes.io/name": "demo" # OK
    "app.kubernetes.io/managed-from": "Git" # OK
    "app.kubernetes.io/managed-by: "Self" # FAILED

Versions:

Client Version: v1.28.6
Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3
Server Version: v1.28.9-eks-036c24b
jonathan-innis commented 1 day ago

resource creation is rejected by adminission controller

Which admission controller is rejecting this? Is this the Kubernetes admission controller or the Karpenter one?