feat: Adding Conversion Webhooks for v1 EC2NodeClass

engedaam commented 1 week ago

Fixes #N/A

Description

Implemented Conversion webhooks for v1 APIs to v1beta1 APIs

How was this change tested?

make presubmit
Planning on Adding E2E testing in a separate PR

Does this change impact docs?

[ ] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[x] No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

coveralls commented 1 week ago

Pull Request Test Coverage Report for Build 9643022481

Details

142 of 228 (62.28%) changed or added relevant lines in 4 files are covered.
67 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-1.2%) to 77.941%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/apis/v1beta1/ec2nodeclass_conversion.go	0	2	0.0%
pkg/webhooks/webhooks.go	0	5	0.0%
pkg/apis/v1/zz_generated.deepcopy.go	0	79	0.0%
<!--	Total:	142	228	62.28%	-->

Files with Coverage Reduction	New Missed Lines	%
pkg/apis/v1/zz_generated.deepcopy.go	67	0.0%
<!--	Total:	67		-->

Totals
Change from base Build 9605900487:	-1.2%
Covered Lines:	5717
Relevant Lines:	7335

💛 - Coveralls

coveralls commented 1 week ago

Pull Request Test Coverage Report for Build 9643330227

Details

142 of 228 (62.28%) changed or added relevant lines in 4 files are covered.
67 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-1.2%) to 77.941%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/apis/v1beta1/ec2nodeclass_conversion.go	0	2	0.0%
pkg/webhooks/webhooks.go	0	5	0.0%
pkg/apis/v1/zz_generated.deepcopy.go	0	79	0.0%
<!--	Total:	142	228	62.28%	-->

Files with Coverage Reduction	New Missed Lines	%
pkg/apis/v1/zz_generated.deepcopy.go	67	0.0%
<!--	Total:	67		-->

Totals
Change from base Build 9605900487:	-1.2%
Covered Lines:	5717
Relevant Lines:	7335

💛 - Coveralls

coveralls commented 1 week ago

Pull Request Test Coverage Report for Build 9666523048

Details

156 of 242 (64.46%) changed or added relevant lines in 4 files are covered.
68 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-1.1%) to 77.97%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/apis/v1beta1/ec2nodeclass_conversion.go	0	2	0.0%
pkg/webhooks/webhooks.go	0	5	0.0%
pkg/apis/v1/zz_generated.deepcopy.go	0	79	0.0%
<!--	Total:	156	242	64.46%	-->

Files with Coverage Reduction	New Missed Lines	%
pkg/providers/amifamily/ami.go	1	90.56%
pkg/apis/v1/zz_generated.deepcopy.go	67	0.0%
<!--	Total:	68	-->

Totals
Change from base Build 9605900487:	-1.1%
Covered Lines:	5730
Relevant Lines:	7349

💛 - Coveralls

coveralls commented 1 week ago

Pull Request Test Coverage Report for Build 9671214967

Details

156 of 242 (64.46%) changed or added relevant lines in 4 files are covered.
68 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-1.1%) to 77.97%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/apis/v1beta1/ec2nodeclass_conversion.go	0	2	0.0%
pkg/webhooks/webhooks.go	0	5	0.0%
pkg/apis/v1/zz_generated.deepcopy.go	0	79	0.0%
<!--	Total:	156	242	64.46%	-->

Files with Coverage Reduction	New Missed Lines	%
pkg/providers/amifamily/ami.go	1	90.56%
pkg/apis/v1/zz_generated.deepcopy.go	67	0.0%
<!--	Total:	68	-->

Totals
Change from base Build 9605900487:	-1.1%
Covered Lines:	5730
Relevant Lines:	7349

💛 - Coveralls

coveralls commented 6 days ago

Pull Request Test Coverage Report for Build 9683589959

Details

156 of 242 (64.46%) changed or added relevant lines in 4 files are covered.
67 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-1.1%) to 78.011%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/apis/v1beta1/ec2nodeclass_conversion.go	0	2	0.0%
pkg/webhooks/webhooks.go	0	5	0.0%
pkg/apis/v1/zz_generated.deepcopy.go	0	79	0.0%
<!--	Total:	156	242	64.46%	-->

Files with Coverage Reduction	New Missed Lines	%
pkg/apis/v1/zz_generated.deepcopy.go	67	0.0%
<!--	Total:	67		-->

Totals
Change from base Build 9605900487:	-1.1%
Covered Lines:	5733
Relevant Lines:	7349

💛 - Coveralls

netlify[bot] commented 1 day ago

Deploy Preview for karpenter-docs-prod canceled.

Name	Link
Latest commit	44ed19572aa81ab867a2458d6917509f369d1bb4
Latest deploy log	https://app.netlify.com/sites/karpenter-docs-prod/deploys/6682bf338d167b0007088097

netlify[bot] commented 1 day ago

Deploy Preview for karpenter-docs-prod canceled.

Name	Link
Latest commit	96af331d1fea7c835993f471191d3f84c4713eaf
Latest deploy log	https://app.netlify.com/sites/karpenter-docs-prod/deploys/6682c28f5dc20b00081da174

coveralls commented 1 day ago

Pull Request Test Coverage Report for Build 9746241181

Details

156 of 163 (95.71%) changed or added relevant lines in 3 files are covered.
114 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.3%) to 77.988%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/apis/v1beta1/ec2nodeclass_conversion.go	0	2	0.0%
pkg/webhooks/webhooks.go	0	5	0.0%
<!--	Total:	156	163	95.71%	-->

Files with Coverage Reduction	New Missed Lines	%
pkg/apis/v1/zz_generated.deepcopy.go	114	0.0%
<!--	Total:	114		-->

Totals
Change from base Build 9739358800:	-0.3%
Covered Lines:	5729
Relevant Lines:	7346

💛 - Coveralls

coveralls commented 1 day ago

Pull Request Test Coverage Report for Build 9746292136

Details

156 of 163 (95.71%) changed or added relevant lines in 3 files are covered.
68 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.3%) to 78.041%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/apis/v1beta1/ec2nodeclass_conversion.go	0	2	0.0%
pkg/webhooks/webhooks.go	0	5	0.0%
<!--	Total:	156	163	95.71%	-->

Files with Coverage Reduction	New Missed Lines	%
pkg/apis/v1/zz_generated.deepcopy.go	68	0.0%
<!--	Total:	68		-->

Totals
Change from base Build 9739358800:	-0.3%
Covered Lines:	5729
Relevant Lines:	7341

💛 - Coveralls

coveralls commented 1 day ago

Pull Request Test Coverage Report for Build 9746312855

Details

156 of 163 (95.71%) changed or added relevant lines in 3 files are covered.
68 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-2.4%) to 75.927%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/apis/v1beta1/ec2nodeclass_conversion.go	0	2	0.0%
pkg/webhooks/webhooks.go	0	5	0.0%
<!--	Total:	156	163	95.71%	-->

Files with Coverage Reduction	New Missed Lines	%
pkg/apis/v1/zz_generated.deepcopy.go	68	0.0%
<!--	Total:	68		-->

Totals
Change from base Build 9739358800:	-2.4%
Covered Lines:	5731
Relevant Lines:	7548

💛 - Coveralls

coveralls commented 1 day ago

Pull Request Test Coverage Report for Build 9746336496

Details

156 of 163 (95.71%) changed or added relevant lines in 3 files are covered.
32 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.4%) to 78.71%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/apis/v1beta1/ec2nodeclass_conversion.go	0	2	0.0%
pkg/webhooks/webhooks.go	0	5	0.0%
<!--	Total:	156	163	95.71%	-->

Files with Coverage Reduction	New Missed Lines	%
pkg/providers/amifamily/ami.go	1	90.56%
pkg/apis/v1/ec2nodeclass_validation.go	31	70.05%
<!--	Total:	32	-->

Totals
Change from base Build 9739358800:	0.4%
Covered Lines:	5941
Relevant Lines:	7548

💛 - Coveralls

coveralls commented 1 day ago

Pull Request Test Coverage Report for Build 9746345571

Details

156 of 163 (95.71%) changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.4%) to 78.723%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/apis/v1beta1/ec2nodeclass_conversion.go	0	2	0.0%
pkg/webhooks/webhooks.go	0	5	0.0%
<!--	Total:	156	163	95.71%	-->

Totals
Change from base Build 9739358800:	0.4%
Covered Lines:	5942
Relevant Lines:	7548

💛 - Coveralls

coveralls commented 1 day ago

Pull Request Test Coverage Report for Build 9746350409

Details

156 of 163 (95.71%) changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.4%) to 78.723%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/apis/v1beta1/ec2nodeclass_conversion.go	0	2	0.0%
pkg/webhooks/webhooks.go	0	5	0.0%
<!--	Total:	156	163	95.71%	-->

Totals
Change from base Build 9739358800:	0.4%
Covered Lines:	5942
Relevant Lines:	7548

💛 - Coveralls

coveralls commented 1 day ago

Pull Request Test Coverage Report for Build 9746361089

Details

156 of 163 (95.71%) changed or added relevant lines in 3 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.4%) to 78.71%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/apis/v1beta1/ec2nodeclass_conversion.go	0	2	0.0%
pkg/webhooks/webhooks.go	0	5	0.0%
<!--	Total:	156	163	95.71%	-->

Files with Coverage Reduction	New Missed Lines	%
pkg/providers/amifamily/ami.go	1	90.56%
<!--	Total:	1		-->

Totals
Change from base Build 9739358800:	0.4%
Covered Lines:	5941
Relevant Lines:	7548

💛 - Coveralls

coveralls commented 1 day ago

Pull Request Test Coverage Report for Build 9746387551

Details

156 of 163 (95.71%) changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.4%) to 78.723%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/apis/v1beta1/ec2nodeclass_conversion.go	0	2	0.0%
pkg/webhooks/webhooks.go	0	5	0.0%
<!--	Total:	156	163	95.71%	-->

Totals
Change from base Build 9739358800:	0.4%
Covered Lines:	5942
Relevant Lines:	7548

💛 - Coveralls

coveralls commented 1 day ago

Pull Request Test Coverage Report for Build 9746413280

Details

156 of 163 (95.71%) changed or added relevant lines in 3 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.4%) to 78.699%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/apis/v1beta1/ec2nodeclass_conversion.go	0	2	0.0%
pkg/webhooks/webhooks.go	0	5	0.0%
<!--	Total:	156	163	95.71%	-->

Files with Coverage Reduction	New Missed Lines	%
pkg/providers/amifamily/ami.go	1	90.56%
<!--	Total:	1		-->

Totals
Change from base Build 9739358800:	0.4%
Covered Lines:	5941
Relevant Lines:	7549

💛 - Coveralls

coveralls commented 1 day ago

Pull Request Test Coverage Report for Build 9746443268

Details

156 of 163 (95.71%) changed or added relevant lines in 3 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.4%) to 78.726%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/apis/v1beta1/ec2nodeclass_conversion.go	0	2	0.0%
pkg/webhooks/webhooks.go	0	5	0.0%
<!--	Total:	156	163	95.71%	-->

Files with Coverage Reduction	New Missed Lines	%
pkg/providers/amifamily/ami.go	1	90.56%
<!--	Total:	1		-->

Totals
Change from base Build 9739358800:	0.4%
Covered Lines:	5943
Relevant Lines:	7549

aws / karpenter-provider-aws