aws / karpenter-provider-aws

Karpenter is a Kubernetes Node Autoscaler built for flexibility, performance, and simplicity.
https://karpenter.sh
Apache License 2.0
6.68k stars 933 forks source link

feat: Karpenter should warn upon using likely incorrect labels in NodePools #6401

Closed aviatus closed 2 months ago

aviatus commented 3 months ago

Fixes #5521

Description Added new requirements label restriction on nodepool crd to prevent nodes starting with random label due to label "eks.amazonaws.com/capacityType".

How was this change tested? The new node pool crd was deployed and tested via the test nodepool with "eks.amazonaws.com/capacityType" on eks cluster.

Does this change impact docs?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

netlify[bot] commented 3 months ago

Deploy Preview for karpenter-docs-prod canceled.

Name Link
Latest commit f6ec289447bc553c5baf27398be64470dd2d22dd
Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/66795ba6bc972b00089074dc
github-actions[bot] commented 2 months ago

This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity.