test: Fix private cluster test failure - Githubissues

aws / karpenter-provider-aws

Karpenter is a Kubernetes Node Autoscaler built for flexibility, performance, and simplicity.

https://karpenter.sh

Apache License 2.0

6.15k stars 849 forks source link

test: Fix private cluster test failure #6403

Closed jigisha620 closed 6 days ago

jigisha620 commented 1 week ago

Fixes #N/A

Description We have been seeing failure in the private cluster test run. This PR adds a fix for it.

How was this change tested? Tested on private cluster in my account

Does this change impact docs?

[ ] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[x] No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

netlify[bot] commented 1 week ago

Deploy Preview for karpenter-docs-prod ready!

Name	Link
Latest commit	23c5e041c92ba839007882848c71ed37d552b2d9
Latest deploy log	https://app.netlify.com/sites/karpenter-docs-prod/deploys/667c4e985527b9000856c6e0
Deploy Preview	https://deploy-preview-6403--karpenter-docs-prod.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

coveralls commented 1 week ago

Pull Request Test Coverage Report for Build 9669508663

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 82.481%

Totals
Change from base Build 9648474245:	0.0%
Covered Lines:	5551
Relevant Lines:	6730

💛 - Coveralls

coveralls commented 1 week ago

Pull Request Test Coverage Report for Build 9670001253

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 82.481%

Totals
Change from base Build 9669988716:	0.0%
Covered Lines:	5551
Relevant Lines:	6730

💛 - Coveralls

coveralls commented 6 days ago

Pull Request Test Coverage Report for Build 9683630921

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 82.481%

Totals
Change from base Build 9674251251:	0.0%
Covered Lines:	5551
Relevant Lines:	6730

💛 - Coveralls

coveralls commented 6 days ago

Pull Request Test Coverage Report for Build 9684055018

Details

0 of 0 changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.01%) to 82.467%

Files with Coverage Reduction	New Missed Lines	%
pkg/providers/amifamily/ami.go	1	90.56%
<!--	Total:	1		-->

Totals
Change from base Build 9684045990:	-0.01%
Covered Lines:	5550
Relevant Lines:	6730

💛 - Coveralls