search

aws / karpenter-provider-aws

Karpenter is a Kubernetes Node Autoscaler built for flexibility, performance, and simplicity.
https://karpenter.sh
Apache License 2.0
6.15k stars 849 forks source link

adding a new interface for ami resolver #6404

Closed ravisinha0506 closed 1 day ago

ravisinha0506 commented 1 week ago

ci: Adding a new interface for AMI resolver

Description Adding a new interface for AMI resolver as this class didn't have any existing interface which makes it tightly coupled with LaunchTemplateProvider.

How was this change tested? I haven't tested this change locally

Does this change impact docs?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

netlify[bot] commented 1 week ago

Deploy Preview for karpenter-docs-prod ready!

Name Link
Latest commit fc8ba10e0c9d93134abd3305d619dd149f97f1b1
Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/667c353e0144d000089b4994
Deploy Preview https://deploy-preview-6404--karpenter-docs-prod.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

coveralls commented 1 week ago

Pull Request Test Coverage Report for Build 9671908957

Details

Totals Coverage Status
Change from base Build 9669988716: 0.03%
Covered Lines: 5553
Relevant Lines: 6730
💛 - Coveralls
coveralls commented 6 days ago

Pull Request Test Coverage Report for Build 9682622659

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

Totals Coverage Status
Change from base Build 9669988716: 0.0%
Covered Lines: 5551
Relevant Lines: 6730
💛 - Coveralls