docs: Scheduling concept doc GPU taint example value: true bool should be a string

samnf commented 1 week ago

Quoting bool value in gpu taint example

Fixes #N/A

Description

Following this documentation, I applied the taint as shown

taints: 
  - key: nvidia.com/gpu
    value: true
    effect: "NoSchedule"

and got an error

NodePool.karpenter.sh "gpu" is invalid: [spec.template.spec.taints[0].value: Invalid value: "boolean": spec.template.spec.taints[0].value in body must be of type string: "boolean"

Quoting the true applied successfully. Also see here where the same example is already quoted: https://karpenter.sh/docs/concepts/nodepools/

How was this change tested? Previewed the scheduling.md

Does this change impact docs?

[x] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[ ] No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

netlify[bot] commented 1 week ago

Deploy Preview for karpenter-docs-prod ready!

Name	Link
Latest commit	b82d2c078dcf9a7b929caf1641640a6b8be3a468
Latest deploy log	https://app.netlify.com/sites/karpenter-docs-prod/deploys/667baa226cae2f00083af510
Deploy Preview	https://deploy-preview-6405--karpenter-docs-prod.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

jonathan-innis commented 1 week ago

Thanks for catching this @samnf!

coveralls commented 1 week ago

Pull Request Test Coverage Report for Build 9674197252

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 82.481%

Totals
Change from base Build 9669988716:	0.0%
Covered Lines:	5551
Relevant Lines:	6730

aws / karpenter-provider-aws