chore: Update GetSupportedNodeClasses to return []status.Object

jigisha620 commented 3 months ago

Fixes #N/A

Description This PR adds a change to return []status.object from GetSupportedNodeClasses

How was this change tested? Tested on local cluster

Does this change impact docs?

[ ] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[x] No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

netlify[bot] commented 3 months ago

Deploy Preview for karpenter-docs-prod canceled.

Name	Link
Latest commit	aaca67639c645f6b01aef089afe44b8b17b9a99e
Latest deploy log	https://app.netlify.com/sites/karpenter-docs-prod/deploys/668c29fb00673e0008d70d59

coveralls commented 3 months ago

Pull Request Test Coverage Report for Build 9719173984

Details

0 of 8 (0.0%) changed or added relevant lines in 2 files are covered.
2 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.04%) to 78.295%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/cloudprovider/cloudprovider.go	0	4	0.0%
pkg/fake/cloudprovider.go	0	4	0.0%
<!--	Total:	0	8	0.0%	-->

Files with Coverage Reduction	New Missed Lines	%
pkg/cloudprovider/cloudprovider.go	1	73.28%
pkg/fake/cloudprovider.go	1	0.0%
<!--	Total:	2	-->

Totals
Change from base Build 9717381388:	-0.04%
Covered Lines:	5786
Relevant Lines:	7390

Pull Request Test Coverage Report for Build 9753011005

Details

0 of 4 (0.0%) changed or added relevant lines in 2 files are covered.
2 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.01%) to 78.434%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/cloudprovider/cloudprovider.go	0	2	0.0%
pkg/fake/cloudprovider.go	0	2	0.0%
<!--	Total:	0	4	0.0%	-->

Files with Coverage Reduction	New Missed Lines	%
pkg/cloudprovider/cloudprovider.go	1	73.88%
pkg/fake/cloudprovider.go	1	0.0%
<!--	Total:	2	-->

Totals
Change from base Build 9752794287:	0.01%
Covered Lines:	5801
Relevant Lines:	7396

💛 - Coveralls

github-actions[bot] commented 2 months ago

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-55bad29e4e2799b55fc93b0b1889d81086790cfb. To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-55bad29e4e2799b55fc93b0b1889d81086790cfb" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

coveralls commented 2 months ago

Pull Request Test Coverage Report for Build 9813097959

Details

0 of 4 (0.0%) changed or added relevant lines in 2 files are covered.
2 unchanged lines in 2 files lost coverage.
Overall coverage remained the same at 78.749%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/cloudprovider/cloudprovider.go	0	2	0.0%
pkg/fake/cloudprovider.go	0	2	0.0%
<!--	Total:	0	4	0.0%	-->

Files with Coverage Reduction	New Missed Lines	%
pkg/cloudprovider/cloudprovider.go	1	73.88%
pkg/fake/cloudprovider.go	1	0.0%
<!--	Total:	2	-->

Totals
Change from base Build 9786416051:	0.0%
Covered Lines:	5940
Relevant Lines:	7543

💛 - Coveralls

coveralls commented 2 months ago

Pull Request Test Coverage Report for Build 9813218711

Details

0 of 4 (0.0%) changed or added relevant lines in 2 files are covered.
2 unchanged lines in 2 files lost coverage.
Overall coverage remained the same at 78.749%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/cloudprovider/cloudprovider.go	0	2	0.0%
pkg/fake/cloudprovider.go	0	2	0.0%
<!--	Total:	0	4	0.0%	-->

Files with Coverage Reduction	New Missed Lines	%
pkg/cloudprovider/cloudprovider.go	1	73.88%
pkg/fake/cloudprovider.go	1	0.0%
<!--	Total:	2	-->

Totals
Change from base Build 9786416051:	0.0%
Covered Lines:	5940
Relevant Lines:	7543

💛 - Coveralls

github-actions[bot] commented 2 months ago

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-04165e819237b08d29fefa4529ad2eea7873ce87. To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-04165e819237b08d29fefa4529ad2eea7873ce87" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

coveralls commented 2 months ago

Pull Request Test Coverage Report for Build 9844631660

Details

0 of 4 (0.0%) changed or added relevant lines in 2 files are covered.
2 unchanged lines in 2 files lost coverage.
Overall coverage remained the same at 78.842%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/cloudprovider/cloudprovider.go	0	2	0.0%
pkg/fake/cloudprovider.go	0	2	0.0%
<!--	Total:	0	4	0.0%	-->

Files with Coverage Reduction	New Missed Lines	%
pkg/cloudprovider/cloudprovider.go	1	73.88%
pkg/fake/cloudprovider.go	1	0.0%
<!--	Total:	2	-->

Totals
Change from base Build 9844518117:	0.0%
Covered Lines:	5951
Relevant Lines:	7548

💛 - Coveralls

github-actions[bot] commented 2 months ago

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-aaca67639c645f6b01aef089afe44b8b17b9a99e. To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-aaca67639c645f6b01aef089afe44b8b17b9a99e" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

aws / karpenter-provider-aws