feat: Add kubelet configuration to EC2NodeClass V1 API

engedaam commented 6 days ago

Fixes #N/A

Description

Add kubelet configuration to the EC2NodeClass for the V1 API. Since the NodePool for v1 API will drop the kubelet configuration, the EC2NodeClass will need to support the field.

How was this change tested?

`make presubmit

Does this change impact docs?

[ ] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[x] No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

netlify[bot] commented 6 days ago

Deploy Preview for karpenter-docs-prod canceled.

Name	Link
Latest commit	da686a1450a9816f105dc78edd30e4277575fa93
Latest deploy log	https://app.netlify.com/sites/karpenter-docs-prod/deploys/667dec956dcd21000854a53c

coveralls commented 6 days ago

Pull Request Test Coverage Report for Build 9691641086

Details

1 of 79 (1.27%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.8%) to 78.266%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/apis/v1/zz_generated.deepcopy.go	1	79	1.27%
<!--	Total:	1	79	1.27%	-->

Totals
Change from base Build 9691055348:	-0.8%
Covered Lines:	5787
Relevant Lines:	7394

💛 - Coveralls

coveralls commented 5 days ago

Pull Request Test Coverage Report for Build 9691723908

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

1 of 79 (1.27%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.8%) to 78.266%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/apis/v1/zz_generated.deepcopy.go	1	79	1.27%
<!--	Total:	1	79	1.27%	-->

Totals
Change from base Build 9691055348:	-0.8%
Covered Lines:	5787
Relevant Lines:	7394

💛 - Coveralls

coveralls commented 5 days ago

Pull Request Test Coverage Report for Build 9691801176

Details

1 of 79 (1.27%) changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.8%) to 78.266%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/apis/v1/zz_generated.deepcopy.go	1	79	1.27%
<!--	Total:	1	79	1.27%	-->

Files with Coverage Reduction	New Missed Lines	%
pkg/providers/amifamily/ami.go	1	90.56%
<!--	Total:	1		-->

Totals
Change from base Build 9691760501:	-0.8%
Covered Lines:	5787
Relevant Lines:	7394

💛 - Coveralls

coveralls commented 5 days ago

Pull Request Test Coverage Report for Build 9692014160

Details

1 of 79 (1.27%) changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.8%) to 78.266%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/apis/v1/zz_generated.deepcopy.go	1	79	1.27%
<!--	Total:	1	79	1.27%	-->

Files with Coverage Reduction	New Missed Lines	%
pkg/providers/amifamily/ami.go	1	90.56%
<!--	Total:	1		-->

Totals
Change from base Build 9691760501:	-0.8%
Covered Lines:	5787
Relevant Lines:	7394

💛 - Coveralls

coveralls commented 5 days ago

Pull Request Test Coverage Report for Build 9692036061

Details

1 of 79 (1.27%) changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.8%) to 78.266%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/apis/v1/zz_generated.deepcopy.go	1	79	1.27%
<!--	Total:	1	79	1.27%	-->

Files with Coverage Reduction	New Missed Lines	%
pkg/providers/amifamily/ami.go	1	90.56%
<!--	Total:	1		-->

Totals
Change from base Build 9691760501:	-0.8%
Covered Lines:	5787
Relevant Lines:	7394

💛 - Coveralls

engedaam commented 5 days ago

What do you mean? What is only available on 1.25+?

coveralls commented 5 days ago

Pull Request Test Coverage Report for Build 9704575948

Details

1 of 79 (1.27%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.8%) to 78.324%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/apis/v1/zz_generated.deepcopy.go	1	79	1.27%
<!--	Total:	1	79	1.27%	-->

Totals
Change from base Build 9704271327:	-0.8%
Covered Lines:	5785
Relevant Lines:	7386

💛 - Coveralls

coveralls commented 5 days ago

Pull Request Test Coverage Report for Build 9704641128

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

1 of 79 (1.27%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.8%) to 78.337%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/apis/v1/zz_generated.deepcopy.go	1	79	1.27%
<!--	Total:	1	79	1.27%	-->

Totals
Change from base Build 9704271327:	-0.8%
Covered Lines:	5786
Relevant Lines:	7386

aws / karpenter-provider-aws