chore: Adding print columns for v1 EC2NodeClass - Githubissues

aws / karpenter-provider-aws

Karpenter is a Kubernetes Node Autoscaler built for flexibility, performance, and simplicity.

https://karpenter.sh

Apache License 2.0

6.15k stars 849 forks source link

chore: Adding print columns for v1 EC2NodeClass #6424

Closed engedaam closed 4 days ago

engedaam commented 5 days ago

Fixes #N/A

Description

Old EC2NodeClass Column
```
NAME      AGE
default   2d8h
```

New EC2NodeClass Column

NAME           READY   AGE   ROLE
default        True    14h   KarpenterNodeRole-aengeda-karpenter-playground-us-west-2

v1 RFC: https://github.com/kubernetes-sigs/karpenter/pull/1222

How was this change tested?

make presubmit

Does this change impact docs?

[ ] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[x] No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

netlify[bot] commented 5 days ago

Deploy Preview for karpenter-docs-prod ready!

Name	Link
Latest commit	67740194759726845f2eaf2247adc7d2b6130311
Latest deploy log	https://app.netlify.com/sites/karpenter-docs-prod/deploys/667f41d228926a0008dd0e89
Deploy Preview	https://deploy-preview-6424--karpenter-docs-prod.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

coveralls commented 5 days ago

Pull Request Test Coverage Report for Build 9704762346

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.01%) to 79.171%

Totals
Change from base Build 9704659664:	0.01%
Covered Lines:	5785
Relevant Lines:	7307

💛 - Coveralls

coveralls commented 4 days ago

Pull Request Test Coverage Report for Build 9708559345

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.03%) to 79.184%

Totals
Change from base Build 9704659664:	0.03%
Covered Lines:	5786
Relevant Lines:	7307

💛 - Coveralls

coveralls commented 4 days ago

Pull Request Test Coverage Report for Build 9719480723

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 78.337%

Totals
Change from base Build 9717381388:	0.0%
Covered Lines:	5786
Relevant Lines:	7386

💛 - Coveralls