search

aws / karpenter-provider-aws

Karpenter is a Kubernetes Node Autoscaler built for flexibility, performance, and simplicity.
https://karpenter.sh
Apache License 2.0
6.15k stars 849 forks source link

chore: Fill in the NodeClassReference for all NodePools and NodeClaims #6427

Closed jonathan-innis closed 1 day ago

jonathan-innis commented 4 days ago

Fixes #N/A

Description

This updates our NodeClassReferences to include all fields for APIVersion and Kind

How was this change tested?

make presubmit /karpenter snapshot

Does this change impact docs?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

netlify[bot] commented 4 days ago

Deploy Preview for karpenter-docs-prod canceled.

Name Link
Latest commit 3b8f3b972b7ccee36ad1b45024a23d3cbb3fb7d1
Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/66833f734c842000084b7efd
github-actions[bot] commented 4 days ago

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-d9921252671aa4b9e785a4cafc1ab67286b67cac. To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-d9921252671aa4b9e785a4cafc1ab67286b67cac" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait
coveralls commented 4 days ago

Pull Request Test Coverage Report for Build 9717592419

Details

Totals Coverage Status
Change from base Build 9717381388: 0.0%
Covered Lines: 5786
Relevant Lines: 7386
💛 - Coveralls
coveralls commented 4 days ago

Pull Request Test Coverage Report for Build 9720211595

Details

Files with Coverage Reduction New Missed Lines %
pkg/providers/amifamily/ami.go 1 90.56%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 9720043516: -0.01%
Covered Lines: 5785
Relevant Lines: 7386
💛 - Coveralls
coveralls commented 4 days ago

Pull Request Test Coverage Report for Build 9722259430

Details

Files with Coverage Reduction New Missed Lines %
pkg/webhooks/webhooks.go 3 0.0%
<!-- Total: 3 -->
Totals Coverage Status
Change from base Build 9721549662: 0.01%
Covered Lines: 5786
Relevant Lines: 7386
💛 - Coveralls
github-actions[bot] commented 4 days ago

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-7e5e9eb662ffd647758e4adf003cb5269baec175. To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-7e5e9eb662ffd647758e4adf003cb5269baec175" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait