aws / karpenter-provider-aws

Karpenter is a Kubernetes Node Autoscaler built for flexibility, performance, and simplicity.
https://karpenter.sh
Apache License 2.0
6.77k stars 953 forks source link

CRDs in git release differ from CRDs rendered by karpenter-crd helm chart #6889

Closed raidlman closed 1 month ago

raidlman commented 2 months ago

Description

Observed Behavior:

Rendering the CRDs via kustomize results in a different manifest than rendering with helm.

The CRDs installed via the helm chart remove the post-install webhook (cf. #6837). The CRDs in the Karpenter release still contain the webhook.

Expected Behavior:

CRDs should be the same for both within the same release.

Reproduction Steps (Please include YAML):

apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
resources:
  - https://raw.githubusercontent.com/aws/karpenter-provider-aws/v0.37.2/pkg/apis/crds/karpenter.sh_nodepools.yaml
  - https://raw.githubusercontent.com/aws/karpenter-provider-aws/v0.37.2/pkg/apis/crds/karpenter.sh_nodeclaims.yaml
  - https://raw.githubusercontent.com/aws/karpenter-provider-aws/v0.37.2/pkg/apis/crds/karpenter.k8s.aws_ec2nodeclasses.yaml
helm template karpenter-crd oci://public.ecr.aws/karpenter/karpenter-crd --version 0.37.2

Versions:

booleanbetrayal commented 2 months ago

@raidlman - you may wish to follow the thread @ #6847

engedaam commented 2 months ago

The CRDs from the karpenter-crd chart are able to be templatized as karpenter helm chart cannot. You should use the karpenter-crd as the mechanism to manage your CRDs.

github-actions[bot] commented 1 month ago

This issue has been inactive for 14 days. StaleBot will close this stale issue after 14 more days of inactivity.