CRD Helm chart v0.37.0-v1.0.0 release issues

[pvickery-ParamountCommerce]

Description

Observed Behavior: Conversion webhooks are added to the CRDs in v0.37.0 but they were not supposed to be added until v1.0.0

This looks related to https://github.com/aws/karpenter-provider-aws/issues/6897 and https://github.com/aws/karpenter-provider-aws/issues/6889

Expected Behavior: No conversion webhooks are used in karpenter-crd v0.37.0

Reproduction Steps (Please include YAML): Install karpenter-crd v0.37.0 and karpenter v0.37.0. Errors will occur as follows since karpenter v0.37.0 does not use port 8443

failed to load initial state of resource EC2NodeClass.karpenter.k8s.aws: conversion webhook for karpenter.k8s.aws/v1beta1, Kind=EC2NodeClass failed: Post "https://karpenter.kube-system.svc:8443/conversion/karpenter.k8s.aws?timeout=30s": no service port 8443 found for service "karpenter"

Versions:

• Chart Version: v0.37.0

• Kubernetes Version (kubectl version): any

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request

• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request

• If you are interested in working on this issue or have submitted a pull request, please leave a comment

[booleanbetrayal]

@pvickery-ParamountCommerce - you may wish to follow the thread @ #6847

[engedaam]

The conversion webhook block was added to support rollback from v1.0. You are able to disable the webhooks by using the values of webhook.enabled=false

[pvickery-ParamountCommerce]

The conversion webhook block was added to support rollback from v1.0. You are able to disable the webhooks by using the values of webhook.enabled=false

The default values should not cause an upgrade to break so I think webhook.enabled=false should be the default. At the very least, this information should be included in the notes for upgrading to 0.37.0+.