aws / karpenter-provider-aws

Karpenter is a Kubernetes Node Autoscaler built for flexibility, performance, and simplicity.
https://karpenter.sh
Apache License 2.0
6.89k stars 970 forks source link

Excess error logs upon termination #7264

Open hhamalai opened 1 month ago

hhamalai commented 1 month ago

Description

Observed Behavior: Occasionally Karpenter will print logs with log.level error during shutdown due to context cancellation, e.g.,

getting messages from queue, receiving sqs messages, RequestCanceled: request context canceled caused by: context canceled

Expected Behavior:

Normal operations should not produce error logs. On the other hand, there might be issues where the context is cancelled due to network timeouts, so simply omitting errors here is not a likely option.

Reproduction Steps (Please include YAML):

Versions:

njtran commented 1 month ago

It makes sense to me that we would emit this log on shutdown. What logs are you trying to not emit that are being emitted? Is it just the shutdown logs?