aws / karpenter-provider-aws

Karpenter is a Kubernetes Node Autoscaler built for flexibility, performance, and simplicity.
https://karpenter.sh
Apache License 2.0
6.86k stars 967 forks source link

migrating-from-cas page need to be updated #7394

Open rshiva777 opened 1 week ago

rshiva777 commented 1 week ago

Description

How can the docs be improved?

Karpenter documentation doesnt have the steps provided to create an SQS in the migrate from cas page below, but in helm installation step it is passing "settings.interruptionQueue=${CLUSTER_NAME}" parameter due to which installation is failing showing that there is no queue found

Document link: https://karpenter.sh/preview/getting-started/migrating-from-cas/

Reference command:

helm template karpenter oci://public.ecr.aws/karpenter/karpenter --version "${KARPENTER_VERSION}" --namespace "${KARPENTER_NAMESPACE}" \
    --set "settings.clusterName=${CLUSTER_NAME}" \
    --set "settings.interruptionQueue=${CLUSTER_NAME}" \
    --set "serviceAccount.annotations.eks\.amazonaws\.com/role-arn=arn:${AWS_PARTITION}:iam::${AWS_ACCOUNT_ID}:role/KarpenterControllerRole-${CLUSTER_NAME}" \
    --set controller.resources.requests.cpu=1 \
    --set controller.resources.requests.memory=1Gi \
    --set controller.resources.limits.cpu=1 \
    --set controller.resources.limits.memory=1Gi > karpenter.yaml
mariuskimmina commented 1 week ago

Seems like this now got fixed in #7273

Edit: Actually nvm, that only added the queue to the command