chore: Panic on kubelet compatibility annotation

aws / karpenter-provider-aws

Karpenter is a Kubernetes Node Autoscaler built for flexibility, performance, and simplicity.

https://karpenter.sh

Apache License 2.0

6.86k stars 967 forks source link

chore: Panic on kubelet compatibility annotation #7438

Open engedaam opened 6 hours ago

engedaam commented 6 hours ago

Fixes #N/A

Description

Panic when a nodepool kubelet has not been moved on to the v1 nodeclass kublete configuration

How was this change tested?

Does this change impact docs?

[ ] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[x] No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

netlify[bot] commented 6 hours ago

Deploy Preview for karpenter-docs-prod ready!

Name	Link
Latest commit	5dc684c495cf62efb70d793761146f0c3ad22f85
Latest deploy log	https://app.netlify.com/sites/karpenter-docs-prod/deploys/6744c6584a6dbc00084c3d27
Deploy Preview	https://deploy-preview-7438--karpenter-docs-prod.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

coveralls commented 6 hours ago

Pull Request Test Coverage Report for Build 12016754171

Details

0 of 10 (0.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.1%) to 82.326%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/operator/operator.go	0	10	0.0%
<!--	Total:	0	10	0.0%	-->

Totals
Change from base Build 11999750352:	-0.1%
Covered Lines:	5692
Relevant Lines:	6914

💛 - Coveralls

github-actions[bot] commented 4 hours ago

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-5dc684c495cf62efb70d793761146f0c3ad22f85. To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-5dc684c495cf62efb70d793761146f0c3ad22f85" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait