aws / language-servers

AWS related Language Servers
Apache License 2.0
19 stars 18 forks source link

Remove @smithy/abort-controller to fix browser builds #239

Closed makenneth closed 3 months ago

makenneth commented 3 months ago

Problem

Browser build of qChatServer gets error in runtime in making Q api calls: TypeError: Failed to construct 'Request': Failed to read the 'signal' property from 'RequestInit': Failed to convert value to 'AbortSignal'. According to this issue, https://github.com/aws/aws-sdk-js-v3/issues/4582, we should use browser's native AbortController.

Solution

Browsers have full support for AbortController for a while and AbortController has been part of Node since v15.0.0. So we shouldn't need to install this that package at all. aws-sdk-v3, which the streaming client uses under the hood, does not support 14.x anymore so we can just to remove @smithy/abort-controller

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.