search

aws / language-servers

AWS related Language Servers
Apache License 2.0
19 stars 18 forks source link

Update `patchYamlJsonPackage.js` to handle paths with spaces in `applyPatch` #270

Closed twwildey closed 3 months ago

twwildey commented 3 months ago

Problem

When language-servers is checked out under a directory that contains spaces in the full path, npm install will fail to complete due to patchYamlJsonPackage.js.

Solution

This commit fixes this issue by ensuring file paths are quoted to support spaces in them.

Testing

Ensured npm install succeeds in a directory with spaces in the full path (i.e. under a user's Application Support folder for Sublime Text on OS X).

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

twwildey commented 3 months ago

Updated PR for https://github.com/aws/language-servers/pull/268.

justinmk3 commented 3 months ago

I've once again created the PR: #270

Why? That loses the PR comments. Please just force-push to your existing branch instead of creating new PRs.

twwildey commented 3 months ago

I've updated to use execFileSync instead of execFile.

twwildey commented 3 months ago

I've once again created the PR: #270

Why? That loses the PR comments. Please just force-push to your existing branch instead of creating new PRs.

Truth be told, I haven't used the PR feature for GitHub in ages, and I did not realize you could force-push to update an existing PR.